--------------------- PatchSet 12026 Date: 2008/04/02 01:03:47 Author: hno Branch: SQUID_2_6 Tag: (none) Log: Bug #2283: Fails to parse chunked encoding using chunk extensions A silly typo in the code verifying chunk headers made Squid reject valid headers using chunk extensions as invalid while accepting other garbage.. Members: src/http.c:1.419.2.11->1.419.2.12 Index: squid/src/http.c =================================================================== RCS file: /cvsroot/squid/squid/src/http.c,v retrieving revision 1.419.2.11 retrieving revision 1.419.2.12 diff -u -r1.419.2.11 -r1.419.2.12 --- squid/src/http.c 26 Nov 2007 11:04:30 -0000 1.419.2.11 +++ squid/src/http.c 2 Apr 2008 01:03:47 -0000 1.419.2.12 @@ -1,6 +1,6 @@ /* - * $Id: http.c,v 1.419.2.11 2007/11/26 11:04:30 adrian Exp $ + * $Id: http.c,v 1.419.2.12 2008/04/02 01:03:47 hno Exp $ * * DEBUG: section 11 Hypertext Transfer Protocol (HTTP) * AUTHOR: Harvest Derived @@ -671,7 +671,7 @@ badchunk = 1; while (end && (*end == '\r' || *end == ' ' || *end == '\t')) end++; - if (httpState->chunk_size < 0 || !end || (*end != '\n' && *end == ';')) { + if (httpState->chunk_size < 0 || !end || (*end != '\n' && *end != ';')) { debug(11, 0) ("Invalid chunk header '%s'\n", strBuf(httpState->chunkhdr)); comm_close(fd); return;