------------------------------------------------------------ revno: 11681 revision-id: squid3@treenet.co.nz-20121017001833-ihu1rb7pz4kii4z4 parent: squid3@treenet.co.nz-20121017001240-e7irl66ug4uiwxlx committer: Amos Jeffries branch nick: 3.2 timestamp: Tue 2012-10-16 18:18:33 -0600 message: Fix using assignment as a condition without parentheses ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20121017001833-ihu1rb7pz4kii4z4 # target_branch: http://bzr.squid-cache.org/bzr/squid3/branches\ # /SQUID_3_2 # testament_sha1: 75ef5bf3e822f26beed4f91cdf91464562d1673f # timestamp: 2012-10-17 00:44:16 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/branches\ # /SQUID_3_2 # base_revision_id: squid3@treenet.co.nz-20121017001240-\ # e7irl66ug4uiwxlx # # Begin patch === modified file 'src/ipcache.cc' --- src/ipcache.cc 2012-07-28 05:38:50 +0000 +++ src/ipcache.cc 2012-10-17 00:18:33 +0000 @@ -429,7 +429,7 @@ memset(i->addrs.bad_mask, 0, sizeof(unsigned char) * ipcount); for (j = 0, k = 0; k < ipcount; ++k) { - if ( i->addrs.in_addrs[j] = A[k] ) + if ((i->addrs.in_addrs[j] = A[k])) ++j; else debugs(14, 1, "ipcacheParse: Invalid IP address '" << A[k] << "' in response to '" << name << "'");