------------------------------------------------------------ revno: 11742 revision-id: squid3@treenet.co.nz-20121230074717-y9oekp0bfabt6szv parent: squid3@treenet.co.nz-20121227030145-klmchd0lla761bee fixes bug(s): http://bugs.squid-cache.org/show_bug.cgi?id=3727 author: Tianyin Xu committer: Amos Jeffries branch nick: 3.2 timestamp: Sun 2012-12-30 00:47:17 -0700 message: Bug 3727: kerberos_ldap_group: explicitly assigning a variable to itself Detected by LLVM compiler. ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20121230074717-y9oekp0bfabt6szv # target_branch: http://bzr.squid-cache.org/bzr/squid3/branches\ # /SQUID_3_2 # testament_sha1: 1223a78479d2a37bf39b200297311c7a17158a4c # timestamp: 2012-12-30 07:54:38 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/branches\ # /SQUID_3_2 # base_revision_id: squid3@treenet.co.nz-20121227030145-\ # klmchd0lla761bee # # Begin patch === modified file 'helpers/external_acl/kerberos_ldap_group/support_ldap.cc' --- helpers/external_acl/kerberos_ldap_group/support_ldap.cc 2012-07-28 05:38:50 +0000 +++ helpers/external_acl/kerberos_ldap_group/support_ldap.cc 2012-12-30 07:47:17 +0000 @@ -109,9 +109,6 @@ void *params) { struct ldap_creds *cp = (struct ldap_creds *) params; - url = url; - request = request; - msgid = msgid; return tool_sasl_bind(ld, cp->dn, cp->pw); } #endif @@ -127,9 +124,6 @@ void *params) { struct ldap_creds *cp = (struct ldap_creds *) params; - url = url; - request = request; - msgid = msgid; return ldap_bind_s(ld, cp->dn, cp->pw, LDAP_AUTH_SIMPLE); } @@ -192,9 +186,6 @@ void *params) { struct ldap_creds *cp = (struct ldap_creds *) params; - url = url; - request = request; - msgid = msgid; return tool_sasl_bind(ld, cp->dn, cp->pw); } #endif @@ -211,9 +202,6 @@ { struct ldap_creds *cp = (struct ldap_creds *) params; - url = url; - request = request; - msgid = msgid; return ldap_bind_s(ld, cp->dn, cp->pw, LDAP_AUTH_SIMPLE); } === modified file 'helpers/external_acl/kerberos_ldap_group/support_sasl.cc' --- helpers/external_acl/kerberos_ldap_group/support_sasl.cc 2012-02-05 06:09:46 +0000 +++ helpers/external_acl/kerberos_ldap_group/support_sasl.cc 2012-12-30 07:47:17 +0000 @@ -136,7 +136,6 @@ { const char *dflt = interact->defresult; - flags = flags; switch (interact->id) { case SASL_CB_GETREALM: if (defaults)