------------------------------------------------------------
revno: 11845
revision-id: squid3@treenet.co.nz-20161217100337-qwu9dk3c1m2i8z0l
parent: squid3@treenet.co.nz-20160508124333-3newast2k6d38bv5
fixes bug: http://bugs.squid-cache.org/show_bug.cgi?id=3290
author: Garri Djavadyan <garryd@comnet.uz>
committer: Amos Jeffries <squid3@treenet.co.nz>
branch nick: 3.2
timestamp: Sat 2016-12-17 23:03:37 +1300
message:
  Bug 3290: authenticate_ttl not working for digest authentication
------------------------------------------------------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: squid3@treenet.co.nz-20161217100337-qwu9dk3c1m2i8z0l
# target_branch: http://bzr.squid-cache.org/bzr/squid3/branches\
#   /SQUID_3_2
# testament_sha1: ecc21a39329c10dd68e51e2a08ca65290f6a5d1f
# timestamp: 2016-12-17 10:06:38 +0000
# source_branch: http://bzr.squid-cache.org/bzr/squid3/3.2
# base_revision_id: squid3@treenet.co.nz-20160508124333-\
#   3newast2k6d38bv5
# 
# Begin patch
=== modified file 'src/auth/digest/UserRequest.cc'
--- src/auth/digest/UserRequest.cc	2012-07-28 05:38:50 +0000
+++ src/auth/digest/UserRequest.cc	2016-12-17 10:03:37 +0000
@@ -158,12 +158,7 @@
     auth_user->credentials(Auth::Ok);
 
     /* password was checked and did match */
-    debugs(29, 4, HERE << "user '" << auth_user->username() << "' validated OK");
-
-    /* auth_user is now linked, we reset these values
-     * after external auth occurs anyway */
-    auth_user->expiretime = current_time.tv_sec;
-    return;
+    debugs(29, 4, "user '" << auth_user->username() << "' validated OK");
 }
 
 Auth::Direction

=== modified file 'src/auth/digest/auth_digest.cc'
--- src/auth/digest/auth_digest.cc	2013-01-28 05:39:19 +0000
+++ src/auth/digest/auth_digest.cc	2016-12-17 10:03:37 +0000
@@ -1091,6 +1091,10 @@
          * the user agent won't change user name without warning.
          */
         authDigestUserLinkNonce(digest_user, nonce);
+
+        /* auth_user is now linked, we reset these values
+         * after external auth occurs anyway */
+        auth_user->expiretime = current_time.tv_sec;
     } else {
         debugs(29, 9, HERE << "Found user '" << username << "' in the user cache as '" << auth_user << "'");
         digest_user = static_cast<Auth::Digest::User *>(auth_user.getRaw());