------------------------------------------------------------
revno: 12328
revision-id: chtsanti@users.sourceforge.net-20120925134254-f3rumu2f7jh8xmio
parent: squid3@treenet.co.nz-20120923091453-6s241l7lhivebsvt
committer: Christos Tsantilas <chtsanti@users.sourceforge.net>
branch nick: trunk
timestamp: Tue 2012-09-25 16:42:54 +0300
message:
  Polish the ACLFilledChecklist::fd related documentation
------------------------------------------------------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: chtsanti@users.sourceforge.net-20120925134254-\
#   f3rumu2f7jh8xmio
# target_branch: http://bzr.squid-cache.org/bzr/squid3/trunk/
# testament_sha1: f3491d13bb1c9602649a585dc9f04ec7a66626ab
# timestamp: 2012-09-25 13:52:59 +0000
# source_branch: http://bzr.squid-cache.org/bzr/squid3/trunk/
# base_revision_id: squid3@treenet.co.nz-20120923091453-\
#   6s241l7lhivebsvt
# 
# Begin patch
=== modified file 'src/acl/FilledChecklist.h'
--- src/acl/FilledChecklist.h	2012-08-14 11:53:07 +0000
+++ src/acl/FilledChecklist.h	2012-09-25 13:42:54 +0000
@@ -27,14 +27,15 @@
     ~ACLFilledChecklist();
 
 public:
+    /// The client connection manager
     ConnStateData * conn() const;
 
-    /// uses conn() if available
+    /// The client side fd. It uses conn() if available
     int fd() const;
 
     /// set either conn
     void conn(ConnStateData *);
-    /// set FD
+    /// set the client side FD
     void fd(int aDescriptor);
 
     //int authenticated();

=== modified file 'src/client_side.cc'
--- src/client_side.cc	2012-09-09 17:13:42 +0000
+++ src/client_side.cc	2012-09-25 13:42:54 +0000
@@ -2516,8 +2516,6 @@
 
             ACLFilledChecklist check(Config.ssl_client.cert_error, request, dash_str);
             check.sslErrors = new Ssl::Errors(SQUID_X509_V_ERR_DOMAIN_MISMATCH);
-            if (Comm::IsConnOpen(pinning.serverConnection))
-                check.fd(pinning.serverConnection->fd);
             const bool allowDomainMismatch =
                 check.fastCheck() == ACCESS_ALLOWED;
             delete check.sslErrors;

=== modified file 'src/forward.cc'
--- src/forward.cc	2012-09-13 06:56:05 +0000
+++ src/forward.cc	2012-09-25 13:42:54 +0000
@@ -214,6 +214,12 @@
             assert(err);
             errorAppendEntry(entry, err);
             err = NULL;
+#if USE_SSL
+            if (request->flags.sslPeek && request->clientConnectionManager.valid()) {
+                CallJobHere1(17, 4, request->clientConnectionManager, ConnStateData,
+                             ConnStateData::httpsPeeked, Comm::ConnectionPointer(NULL));
+            }
+#endif
         } else {
             EBIT_CLR(entry->flags, ENTRY_FWD_HDR_WAIT);
             entry->complete();
@@ -369,14 +375,6 @@
             ErrorState *anErr = new ErrorState(ERR_CANNOT_FORWARD, HTTP_INTERNAL_SERVER_ERROR, request);
             fail(anErr);
         } // else use actual error from last connection attempt
-#if USE_SSL
-        if (request->flags.sslPeek && request->clientConnectionManager.valid()) {
-            errorAppendEntry(entry, err); // will free err
-            err = NULL;
-            CallJobHere1(17, 4, request->clientConnectionManager, ConnStateData,
-                         ConnStateData::httpsPeeked, Comm::ConnectionPointer(NULL));
-        }
-#endif
         self = NULL;       // refcounted
     }
 }
@@ -828,7 +826,6 @@
     // The list is used in ssl_verify_cb() and is freed in ssl_free().
     if (acl_access *acl = Config.ssl_client.cert_error) {
         ACLFilledChecklist *check = new ACLFilledChecklist(acl, request, dash_str);
-        check->fd(fd);
         SSL_set_ex_data(ssl, ssl_ex_index_cert_error_check, check);
     }