------------------------------------------------------------
revno: 12359
revision-id: squid3@treenet.co.nz-20121013060300-3lu195j7wi6ugw5i
parent: squid3@treenet.co.nz-20121013060236-epnz84nafzalpp0k
committer: Amos Jeffries <squid3@treenet.co.nz>
branch nick: 3.3
timestamp: Sat 2012-10-13 00:03:00 -0600
message:
  ssl_crtd: set new certificate serial number to zero
  
  Initialize new BN value to zero instead of simply testing and ignoring
  the result.
  
  Detected by Jenkins running clang on FreeBSD 9.
------------------------------------------------------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: squid3@treenet.co.nz-20121013060300-3lu195j7wi6ugw5i
# target_branch: http://bzr.squid-cache.org/bzr/squid3/3.3
# testament_sha1: d56a7f3d3b605a8ed61699360aeea53d8810154c
# timestamp: 2012-10-13 06:07:42 +0000
# source_branch: http://bzr.squid-cache.org/bzr/squid3/3.3
# base_revision_id: squid3@treenet.co.nz-20121013060236-\
#   epnz84nafzalpp0k
# 
# Begin patch
=== modified file 'src/ssl/gadgets.cc'
--- src/ssl/gadgets.cc	2012-10-04 11:10:17 +0000
+++ src/ssl/gadgets.cc	2012-10-13 06:03:00 +0000
@@ -435,7 +435,7 @@
     serial.reset(x509Pubkeydigest(properties.signWithX509));
     if (!serial.get()) {
         serial.reset(BN_new());
-        BN_is_zero(serial.get());
+        BN_zero(serial.get());
     }
 
     if (!generateFakeSslCertificate(fakeCert, fakePkey, properties, serial))