------------------------------------------------------------
revno: 12432
revision-id: squid3@treenet.co.nz-20121230074611-uwb2rze5859am4lj
parent: squid3@treenet.co.nz-20121230074320-tmgtpf8tbdbji2g7
fixes bug(s): http://bugs.squid-cache.org/show_bug.cgi?id=3727
author: Tianyin Xu <tixu@cs.ucsd.edu>
committer: Amos Jeffries <squid3@treenet.co.nz>
branch nick: 3.3
timestamp: Sun 2012-12-30 00:46:11 -0700
message:
  Bug 3727: kerberos_ldap_group: explicitly assigning a variable to itself
  
   Detected by LLVM compiler.
------------------------------------------------------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: squid3@treenet.co.nz-20121230074611-uwb2rze5859am4lj
# target_branch: http://bzr.squid-cache.org/bzr/squid3/3.3
# testament_sha1: dbc9a05c63b3543e03d0e39e758a1f4438199ee3
# timestamp: 2012-12-30 07:54:20 +0000
# source_branch: http://bzr.squid-cache.org/bzr/squid3/3.3
# base_revision_id: squid3@treenet.co.nz-20121230074320-\
#   tmgtpf8tbdbji2g7
# 
# Begin patch
=== modified file 'helpers/external_acl/kerberos_ldap_group/support_ldap.cc'
--- helpers/external_acl/kerberos_ldap_group/support_ldap.cc	2012-12-30 07:43:20 +0000
+++ helpers/external_acl/kerberos_ldap_group/support_ldap.cc	2012-12-30 07:46:11 +0000
@@ -109,9 +109,6 @@
     void *params)
 {
     struct ldap_creds *cp = (struct ldap_creds *) params;
-    url = url;
-    request = request;
-    msgid = msgid;
     return tool_sasl_bind(ld, cp->dn, cp->pw);
 }
 #endif
@@ -127,9 +124,6 @@
     void *params)
 {
     struct ldap_creds *cp = (struct ldap_creds *) params;
-    url = url;
-    request = request;
-    msgid = msgid;
     return ldap_bind_s(ld, cp->dn, cp->pw, LDAP_AUTH_SIMPLE);
 }
 
@@ -192,9 +186,6 @@
     void *params)
 {
     struct ldap_creds *cp = (struct ldap_creds *) params;
-    url = url;
-    request = request;
-    msgid = msgid;
     return tool_sasl_bind(ld, cp->dn, cp->pw);
 }
 #endif
@@ -211,9 +202,6 @@
 {
 
     struct ldap_creds *cp = (struct ldap_creds *) params;
-    url = url;
-    request = request;
-    msgid = msgid;
     return ldap_bind_s(ld, cp->dn, cp->pw, LDAP_AUTH_SIMPLE);
 }
 

=== modified file 'helpers/external_acl/kerberos_ldap_group/support_sasl.cc'
--- helpers/external_acl/kerberos_ldap_group/support_sasl.cc	2012-12-30 07:43:20 +0000
+++ helpers/external_acl/kerberos_ldap_group/support_sasl.cc	2012-12-30 07:46:11 +0000
@@ -134,7 +134,6 @@
 {
     const char *dflt = interact->defresult;
 
-    flags = flags;
     switch (interact->id) {
     case SASL_CB_GETREALM:
         if (defaults)