------------------------------------------------------------ revno: 12613 revision-id: squid3@treenet.co.nz-20130910112813-8sl24qq75ba288n3 parent: squid3@treenet.co.nz-20130910073628-yhvo1u6euf1xt5i3 fixes bug(s): http://bugs.squid-cache.org/show_bug.cgi?id=3077 author: Jan Sievers committer: Amos Jeffries branch nick: 3.3 timestamp: Tue 2013-09-10 05:28:13 -0600 message: Regression Bug 3077: off-by-one error in Digest header decoding This is a regression in the 3.2 and later version of the original bug fix patch. The effect is that all attributes are treated as quoted-string values with unescaping performed. This ends with credentials wrongly being rejected as invalid. ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20130910112813-8sl24qq75ba288n3 # target_branch: http://bzr.squid-cache.org/bzr/squid3/3.3 # testament_sha1: 065fff66da00e3f9a2037b6ff2dbeeeeb1dcbcb5 # timestamp: 2013-09-10 11:53:40 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/3.3 # base_revision_id: squid3@treenet.co.nz-20130910073628-\ # yhvo1u6euf1xt5i3 # # Begin patch === modified file 'src/auth/digest/auth_digest.cc' --- src/auth/digest/auth_digest.cc 2013-01-28 04:16:21 +0000 +++ src/auth/digest/auth_digest.cc 2013-09-10 11:28:13 +0000 @@ -817,7 +817,7 @@ vlen = 0; } - StringArea keyName(item, nlen-1); + StringArea keyName(item, nlen); String value; if (vlen > 0) {