------------------------------------------------------------ revno: 12636 revision-id: squid3@treenet.co.nz-20131024152401-sf8gguj1o0j30lk8 parent: squid3@treenet.co.nz-20131024152314-msq7gavhbo72azea author: Elmar Vonlanthen committer: Amos Jeffries branch nick: 3.3 timestamp: Thu 2013-10-24 09:24:01 -0600 message: ntlm_fake_auth: pass DOMAIN data to Squid in original case Lower-casing the domain field can cause base ACL match results if the ACL is checking for case-sensitive or upper-case domain label. The helper should be emitting the standard UPPER case domain and many administrators will be expecting that when they write ACLs. ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20131024152401-sf8gguj1o0j30lk8 # target_branch: http://bzr.squid-cache.org/bzr/squid3/3.3 # testament_sha1: 12bb9f17c7aaed9745d7ea239918610e3a7a008a # timestamp: 2013-10-24 15:46:48 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/3.3 # base_revision_id: squid3@treenet.co.nz-20131024152314-\ # msq7gavhbo72azea # # Begin patch === modified file 'helpers/ntlm_auth/fake/ntlm_fake_auth.cc' --- helpers/ntlm_auth/fake/ntlm_fake_auth.cc 2012-11-24 02:13:27 +0000 +++ helpers/ntlm_auth/fake/ntlm_fake_auth.cc 2013-10-24 15:24:01 +0000 @@ -224,7 +224,6 @@ } else if (ntlm_validate_packet(packet, NTLM_AUTHENTICATE) == NTLM_ERR_NONE) { if (ntlm_unpack_auth((ntlm_authenticate *)packet, user, domain, decodedLen) == NTLM_ERR_NONE) { lc(user); - lc(domain); if (strip_domain_enabled) { SEND2("AF %s", user); } else { @@ -232,7 +231,6 @@ } } else { lc(user); - lc(domain); SEND4("NA invalid credentials, user=%s%s%s", domain, (*domain?"\\":""), user); } } else {