------------------------------------------------------------ revno: 13745 revision-id: squid3@treenet.co.nz-20150206152624-gkz8imkb78eczo02 parent: squid3@treenet.co.nz-20150201091544-kqejhmyjqudnj4gg fixes bug: http://bugs.squid-cache.org/show_bug.cgi?id=4180 author: Francesco Chemolli committer: Amos Jeffries branch nick: 3.5 timestamp: Fri 2015-02-06 07:26:24 -0800 message: Bug 4180: Fix not-fully-initialized data member in ACLUserData ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20150206152624-gkz8imkb78eczo02 # target_branch: http://bzr.squid-cache.org/bzr/squid3/3.5 # testament_sha1: 82e2b4489b116b1d8799aa0fce76565a30454091 # timestamp: 2015-02-06 15:35:27 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/3.5 # base_revision_id: squid3@treenet.co.nz-20150201091544-\ # kqejhmyjqudnj4gg # # Begin patch === modified file 'src/acl/UserData.cc' --- src/acl/UserData.cc 2015-01-19 13:54:09 +0000 +++ src/acl/UserData.cc 2015-02-06 15:26:24 +0000 @@ -59,6 +59,16 @@ return (lhs.caseCmp(rhs) < 0); } +static bool +CaseSensitveSBufCompare(const SBuf &lhs, const SBuf &rhs) +{ + return (lhs < rhs); +} + +ACLUserData::ACLUserData() : userDataNames(CaseSensitveSBufCompare) +{ +} + void ACLUserData::parse() { === modified file 'src/acl/UserData.h' --- src/acl/UserData.h 2015-01-19 13:54:09 +0000 +++ src/acl/UserData.h 2015-02-06 15:26:24 +0000 @@ -21,6 +21,7 @@ MEMPROXY_CLASS(ACLUserData); virtual ~ACLUserData() {} + ACLUserData(); bool match(char const *user); virtual SBufList dump() const; void parse();