------------------------------------------------------------ revno: 13784 revision-id: squid3@treenet.co.nz-20150327111242-gdcjtscrtzuexjje parent: squid3@treenet.co.nz-20150327104837-ko1jsr2rr2zsg5vl author: Christos Tsantilas committer: Amos Jeffries branch nick: 3.5 timestamp: Fri 2015-03-27 04:12:42 -0700 message: Fix Squid crash while an error page generated When squid generated an error page which contains the "%m" formating code but the authentication information is not available squid dies with segfault. This is a Measurement Factory project ------------------------------------------------------------ # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: squid3@treenet.co.nz-20150327111242-gdcjtscrtzuexjje # target_branch: http://bzr.squid-cache.org/bzr/squid3/3.5 # testament_sha1: 926dc90c45a4ccc6dbd5b9ee0eb505a0383180c4 # timestamp: 2015-03-27 11:51:24 +0000 # source_branch: http://bzr.squid-cache.org/bzr/squid3/3.5 # base_revision_id: squid3@treenet.co.nz-20150327104837-\ # ko1jsr2rr2zsg5vl # # Begin patch === modified file 'src/errorpage.cc' --- src/errorpage.cc 2015-01-13 09:13:49 +0000 +++ src/errorpage.cc 2015-03-27 11:12:42 +0000 @@ -914,7 +914,10 @@ case 'm': if (building_deny_info_url) break; #if USE_AUTH - p = auth_user_request->denyMessage("[not available]"); + if (auth_user_request.getRaw()) + p = auth_user_request->denyMessage("[not available]"); + else + p = "[not available]"; #else p = "-"; #endif