------------------------------------------------------------
revno: 13974
tags: SQUID_3_5_13
revision-id: squid3@treenet.co.nz-20160106143207-abcdxzy3fqbr7rew
parent: squid3@treenet.co.nz-20160106142736-wnvr72gwudw97k2w
author: Christos Tsantilas <chtsanti@users.sourceforge.net>
committer: Amos Jeffries <squid3@treenet.co.nz>
branch nick: 3.5
timestamp: Thu 2016-01-07 03:32:07 +1300
message:
  Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()
  
   ... return non NULL before use the result
  
  Detected by Coverity Scan. Issue 1346998
------------------------------------------------------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: squid3@treenet.co.nz-20160106143207-abcdxzy3fqbr7rew
# target_branch: http://bzr.squid-cache.org/bzr/squid3/3.5
# testament_sha1: 52d290b3966cedeca07d0cc4744a5cd1ed8d69ff
# timestamp: 2016-01-06 14:35:24 +0000
# source_branch: http://bzr.squid-cache.org/bzr/squid3/3.5
# base_revision_id: squid3@treenet.co.nz-20160106142736-\
#   wnvr72gwudw97k2w
# 
# Begin patch
=== modified file 'src/ssl/helper.cc'
--- src/ssl/helper.cc	2016-01-05 15:42:46 +0000
+++ src/ssl/helper.cc	2016-01-06 14:32:07 +0000
@@ -264,6 +264,7 @@
         Ssl::CertValidationResponse::Pointer resp = new Ssl::CertValidationResponse;
         resp->resultCode = ::Helper::BrokenHelper;
         Ssl::CertValidationHelper::CbDialer *dialer = dynamic_cast<Ssl::CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = resp;
         ScheduleCallHere(callback);
         return;
@@ -287,6 +288,7 @@
             (validationResponse = CertValidationHelper::HelperCache->get(crtdvdData->query.c_str()))) {
 
         CertValidationHelper::CbDialer *dialer = dynamic_cast<CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = *validationResponse;
         ScheduleCallHere(callback);
         SSL_free(crtdvdData->ssl);