Re: Problem with ftp proxying

Mike Wohlgemuth wrote:
>
> I have just run into this problem myself.
>
> What follows is a diff for ftpget 1.1.20. It fixes this problem, as
> well as one where Squid drops the password from the BASE tag it returns
> to the browser. Dropping the password doesn't cause problems for
> Netscape, but it confuses Internet Explorer.
>
> There may well be a better way of fixing this second problem. I just
> started looking at the source yesterday, so I might have missed a
> glaringly obvious fix.

Oops. Further testing shows that my patch was buggy. Here is the new
diff, which works much better, I swear!

Mike

383a384,385
> const char *const null_string = "";
>
1657c1659
< sprintf(cbuf, "RETR %s", r->path);

---
>     sprintf(cbuf, "RETR /%s", r->path);
2133a2136,2137
>     static char tmpbuf[BIGBUFSIZ];
> 
2144c2148,2168
<     if (r->flags & F_USEBASE)
---
> 
>     if (r->flags & F_USEBASE) {
> 
> /*
>  *        fprintf(wfp, "<BASE HREF=\"%s\">\n", r->url_escaped);
>  */
> 
>       sprintf(tmpbuf, "%i", r->port);
> 
>       if (strcmp(*r->user, "anonymous")) {
>       fprintf(wfp, "<BASE HREF=\"ftp://%s%s%s%s%s%s%s/%s/\">\n",
>               r->user,
>               *r->pass ? ":" : null_string,
>               r->pass,
>               *r->user ? "@" : null_string,
>               r->host,
>               r->port != 21 ? ":" : null_string,
>               r->port != 21 ? tmpbuf : null_string,
>               r->path);
>       }
>       else {
2145a2170,2172
>       }
>     }
>