Re: squid.1.NOVM.20+retry memory usage report bug

On Thu, 26 Feb 1998, WWW server manager wrote:

> I just noticed a similar problem, with 1.NOVM.20 and a copy of the (NOVM
> version of the) retry patch fetched on 10th Feb.
>
> I'm currently seeing
>
> Pool for disk I/O 85870 x 8192 bytes = 686960 KB ( 0 free)

I was just going through my old e-mail, and found that Kazuyoshi Komine
submitted a patch for this problem on February 21. Here's the patch,
although this looks to have been fixed in 1.1.20...

--------------------------
Maybe I found a bug. That is a statistics of "Pool for disk I/O".
A counter for statistics of "Pool for disk I/O" keep on increasing.
Is that a bug? In storeAbort(), the 8Kbyte memory
for MemObject mem->e_abort_msg is allocated by get_free_8k_page().
I don't know whether the use of get_free_8k_page is necessary or not.
But I understand that is necessary any memorys
for MemObject mem->e_abort_msg.

I thought and made a patch.
This is a patch. This patch may needs further study.
I should be happy to be of any help to you.

*** store.c Sat Feb 21 20:59:57 1998
--- store.c.980220 Sat Feb 21 20:59:13 1998
***************
*** 1334,1340 ****
      }
      e->store_status = STORE_ABORTED;
      if (msg) {
! mem->e_abort_msg = xmalloc(8192);
        strcpy(mem->e_abort_msg, "HTTP/1.0 400 Cache Detected Error\r\n");
        mk_mime_hdr(mem->e_abort_msg + strlen(mem->e_abort_msg),
            "text/html",
--- 1334,1340 ----
      }
      e->store_status = STORE_ABORTED;
      if (msg) {
! mem->e_abort_msg = get_free_8k_page();
        strcpy(mem->e_abort_msg, "HTTP/1.0 400 Cache Detected Error\r\n");
        mk_mime_hdr(mem->e_abort_msg + strlen(mem->e_abort_msg),
            "text/html",

--------------------------------
Kazuyoshi Komine <komine@cc.meisei-u.ac.jp>
Information Science Research Center
Meisei University, Japan
Received on Thu Feb 26 1998 - 09:00:43 MST