Re: Squid crashing with Netcache proxy as parent

At 02:24 AM 11/04/98 GMT, Tom Hardy wrote:
>Hiho,
> Since one of our parents was upgraded to Netcache, it caused
>squid (1.1.17 - 1.1.21 all of those were tested giving the same
>result) to server a few requests then die. The messages were:
>
>
>Apr 11 11:51:49 proxy squid[10631]: Starting Squid Cache version
>1.1.21 for i586-pc-linux-gnu...
>Apr 11 11:51:50 proxy squid[10631]: Ready to serve requests.
>Apr 11 11:51:51 proxy squid[10631]: icpHandleIcpV3: Neighbor
>139.130.255.18 returned reqnum = 0
>Apr 11 11:51:51 proxy squid[10631]: icpHandleIcpV3: Disabling use of
>private keys
><----- cron squid revive --- >
>Apr 11 11:52:54 proxy squid[10650]: Starting Squid Cache version
>1.1.21 for i586-pc-linux-gnu...

Howdy.

I've already reported this to squid-bugs, and Duane came up with the
following patch for me which seems to have stopped the crashing - here 'tis:

Regards

Index: icp.c
===================================================================
RCS file: /surf1/CVS/squid/src/Attic/icp.c,v
retrieving revision 1.210.2.38
diff -w -u -r1.210.2.38 icp.c
--- icp.c 1998/03/17 05:48:09 1.210.2.38
+++ icp.c 1998/03/28 05:34:52
@@ -1928,6 +1928,8 @@
     if ((expectlen - curlen) > Config.quickAbort.max)
        /* too much left to go */
        return 1;
+ if (expectlen <= 0)
+ return 1;
     if ((curlen / (expectlen / 128U)) > Config.quickAbort.pct)
        /* past point of no return */
        return 0;

--
 This message is Copyright (c) 1998 by Karl Ferguson
Tower Networking Pty Ltd    -    Tel: +61 8 9355 0000
t/a STAR Online Services    -    Fax: +61 8 9355 0033