Re: Read timeout POST and mp3.com

Duane Wessels wrote:
>
> Jonathan Larmour writes:
>
> >Perhaps pumpServerCopy() in pump.c should contain the line:
> >
> > commSetTimeout(p->s_fd, Config.Timeout.read, pumpTimeout, p);
> >
> >at the end?
>
> Oops, this is what I was thinking. Being sure to clear the client-side
> read timeout after we've read everything.
>
[snip most of pump.c:pumpReadFromClient() patch]
> + commSetTimeout(p->c_fd, -1, NULL, NULL);

and

> No, probably it should contain
>
> commSetTimeout(p->s_fd, -1, NULL, NULL);
>
> in pumpServerCopyComplete().

Surely neither of these are right? The problem reported was due to a large
POST request where it is not even certain that the MP3 will have been
transmitted to squid in the 15 minutes. Putting the update to s_fd line in
pumpServerCopy() is the only way to keep the server side timeout updated.

And the first patch above wouldn't have any effect since that's only the
client side timeout - which will mostly have already been updated from about
5 lines further up anyway for large requests.

Or am I talking out my posterior?

Jifl

-- 
Cygnus Solutions, 35 Cambridge Place, Cambridge, UK.  Tel: +44 (1223) 728762
"Women marry hoping their husbands will change, men||Home e-mail: jifl @ 
marry hoping their wives never do. Both are rare." ||     jifvik.demon.co.uk
Help fight spam! http://spam.abuse.net/  These opinions are all my own fault