Bug found in 2.3st1 & FIX

From: Pedro Ribeiro <[email protected]>
Date: Mon, 24 Jan 2000 18:26:29 -0000

I'v detected a bug in 'maxconn' acl, the behaviour was the inverse of the
expected, taking a look at acl.c and client_db.c i'v detected the bug
documented in the fallowing diff.

Best Regards.

--- ../squid-2.3.STABLE1/src/acl.c Mon Jan 10 06:10:37 2000
+++ src/acl.c Mon Jan 24 12:18:47 2000
@@ -1374,7 +1374,7 @@
        /* NOTREACHED */
     case ACL_MAXCONN:
        k = clientdbEstablished(checklist->src_addr, 0);
- return ((k > ((intlist *) ae->data)->i) ? 0 : 1);
+ return ((k > ((intlist *) ae->data)->i) ? 1 : 0);
        /* NOTREACHED */
     case ACL_URL_PORT:
        return aclMatchIntegerRange(ae->data, (int) r->port);

[]-------------------------------------------------------------[]
  Pedro Ribeiro
  Online: http://www.isel.pt/~pribeiro/
  IRC(PTnet) Nick: PAntMaR
  e-Mail: Personal: pribeiro@isel.pt / Admin: netadmin@isel.pt
  PGP Key Available in keyservers.
  PGPFP: E848 DCA3 5397 97EF 4CF9 2347 24BD BEF8 D104 1743
[]-------------------------------------------------------------[]
Received on Mon Jan 24 2000 - 11:35:20 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:50:40 MST