I've seen it, and I don't believe it is right. The meat of it:
- if (storeAufsSomethingPending(sio)) {
+ if (FILE_MODE(sio->mode) == O_WRONLY && storeAufsSomethingPending(sio)) {
Why go through the motions of opening/reading/closing when we know we don't need to? It's a waste of cpu/spindle time to retrieve the file once we know the client is no longer listening. Mark it closed as soon as possible, and move on to something useful.
Phil Oester
On Tue, Nov 05, 2002 at 08:56:58AM +1100, Robert Collins wrote:
> Have you seen Henriks suggested alteration as well, to prevent a
> suspected memory overwrite on async writes?
>
> Rob
Received on Mon Nov 04 2002 - 15:57:50 MST
This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 17:11:08 MST