Re: [squid-users] Minimal caching time squid honors

On Sat, 18 Dec 2004, Henrik Nordstrom wrote:

> On Sat, 18 Dec 2004, Thomas Ristic wrote:
>
>> I meant if the way I implement the minimum_expiry_time configuration
>> option in the tiny patch I attached to my last mail looks sane to you.
>
> Sorry, I did not see the patch.

I have now looked at the patch and it looks good. Only one minor thing

- int reason = refreshCheck(entry, NULL, 60);
+ int reason;
+ if (Config.minimum_expiry_time) {
+ reason = refreshCheck(entry, NULL, Config.minimum_expiry_time);
+ } else {
+ reason = refreshCheck(entry, NULL, 60);
+ }

you do not need to check that Config.minimum_expiry_time is non-zero.
Using just

      int reason = refreshCheck(entry, NULL, Config.minimum_expiry_time);

is better. If not it gets somewhat confusing to the administrator that
setting "minimum_expiry_time 0 seconds" makes it use 60 seconds again..

Regards
Henrik
Received on Sat Dec 18 2004 - 07:31:51 MST